Make tabs detachable + minor bugfix

[Vulcalien]

Fixes #302

Note - This pull request is to show the progress. I have done very little testing, so I don't recommend pulling it right now.

About

As said in the issue comments, set_tab_detachable does the job. The code found on StackOverflow gave me a guideline, but much of that stuff is already implemented somewhere in Terminator. So I had to create only one function, create_window_detach.

About self.hoover: without calling that function, if a tab is detached and a notebook only has 2 tabs, the resulting notebook only has 1 tab, causing some troubles.

Most of the work was about reading the documentation.

---

I'll finish testing soon, and maybe fix that Drag-and-drop problem that we were talking about in the comments, since it's related.

[mattrose]

Most of the work was about reading the documentation.

LOL, yep. There's a reason https://lazka.github.io/pgi-docs/ is one of my most-used bookmarks :)

Thanks, I'm curious to see how this is going. I'll likely pull it down and play with it tomorrow morning.

[Vulcalien]

One bug found:

(terminator:92639): Gtk-CRITICAL **: 00:08:00.686: gtk_notebook_get_tab_label: assertion 'list != NULL' failed
Notebook::update_tab_label_text: <terminal.Terminal object at 0x7f436d33f3c0 (terminatorlib+terminal+Terminal at 0x1be29e0)> not found

I ran terminator without -d

Strange stuff. Only happens when you detach a tab from a notebook that contains 3 or more tabs. It doesn't seem to have any effect, other than the error message.

Probably I am missing a function call or something.

[Vulcalien]

Probably I am missing a function call or something.

Yep, self.disconnect_child(widget). It's used in Notebook.remove after a notebook page is removed, and it makes sense to call it after a tab is detached.

---

Edit - there is still this:

<terminal.Terminal object at 0x7f854feefe00 (terminatorlib+terminal+Terminal at 0x16f41a0)> not found in Notebook. Actual parent is: None

To reproduce:

1. create 3 or more tabs
2. detach one of them
3. close the new window
4. close the old window from the X button

[mattrose]

This looks good so far, though I agree definitely not ready for prime time yet.
One debug trick I recommend, you can specify what classes and methods for which you want debug messages to show up, so in this case I would use something like terminator -d --debug-class=Notebook or something like terminator -d --debug-class=Notebook --debug-method=create_window_detach and then you can add dbg messages to figure out what the code is doing better.

[Vulcalien]

Updates

That strange log error is not caused by the detached tabs. I could reproduce it by simply having 3 tabs and then closing the Terminator window (using the GUI "X").
It also happens on older versions (2.1.0).

I've written a dbg message for the new function and done some testing. I think the PR could be ready.

[mattrose]

So, I was playing with this last night, and this error, I believe is caused by (of all things)

terminator/terminatorlib/notebook.py

Line 295 in b20d11e

label.connect('close-clicked', self.closetab)

Which means that clicking anywhere on the label of the tab (basically anywhere in the tab), it can consider that calling closetab. I'd really like to make it so that you have to click on the X button to close the tab.

[Vulcalien]

Which means that clicking anywhere on the label

Wait, if you click the notebook label, the tab closes? I do have to click the X in the tab label to close it.

---

Btw I think I found something related. Window::on_destroy_event, these lines

for terminal in self.get_visible_terminals():
    terminal.close()

If I remove them, I see one more error message (... not found in Notebook. Actual parent is: None...) having the same number of tabs. I think all terminals should be closed, but are not since they are not visible (self.get_visible_terminals() does not return them)

---

Writing this after 10 minutes.
I fixed it! Instead of calling get_visible_terminals (that would close only the ones present in the current tab), close all terminals in the window, whenever they are visible or not (because they are in another notebook tab).

for terminal in self.get_terminals():
    terminal.close()

I'm including this commit in the PR.

[mattrose]

Is this ready to go?

[Vulcalien]

Yep, I think it is.

[mattrose]

Cool, I'll pull it down again and give it a quick once-over before merging it.

[mattrose]

This looks great. Thanks again!