Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated info in some debug messages #576

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

Vulcalien
Copy link
Member

@Vulcalien Vulcalien commented Jan 28, 2022

In the code, we can find code like this:

dbg('ConfigBase::get_item: %s found in globals: %s' %
                    (key, self.global_config[key]))

But this gets printed:

ConfigBase::get_item: ConfigBase::get_item: focus found in globals: click

There is a repetition, because the dbg function already adds the name of the function at the beginning (4d21663).
The same should probably have been done to the err function.

This change should make the debug logs easier to read.

@Vulcalien Vulcalien marked this pull request as ready for review January 28, 2022 21:09
@mattrose
Copy link
Member

Thanks for this, this is something that was an irritant to me up until now.

@mattrose mattrose merged commit fc528b2 into gnome-terminator:master Jan 29, 2022
@Vulcalien Vulcalien deleted the fix-dbg-messages branch January 29, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants