Ask before closing, even if there is only one terminal #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ask_before_closing' replaces 'suppress_multiple_term_dialog'. The function 'Container.construct_confirm_close' was significantly modified. The terminator_config manpage has been updated.
|
@Vulcalien you're amazing and so appreciated, even though I seem to show it by going months without touching Terminator. I'll take a look. |
|
Also love the fact that you fixed docs at the same time. |
|
No worries about the inactive time, we're all volunteers after all. |
|
Merging this. I worked out the Glade for adding a preferences entry for this as well. Now I just have to wire it up. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Partially?) solves #830
This is apparently a very requested feature. This PR makes it possible for the "Close?" confirmation dialog to appear even if there is only one terminal.
Settings: suppress_multiple_term_dialog ---> ask_before_closing
The
suppress_multiple_term_dialogsetting has been replaced withask_before_closing, which can have values 'never', 'multiple_terminals' and 'always'.'multiple_terminals' is the default, so that Terminator's default behavior remains the same. The "Do not show this message next time" checkbox sets
ask_before_closingto 'never', regardless of its previous value.GUI changes
The confirm close dialog is the same as before, for multiple terminals. For one terminal, it is like this:
Code changes
Container.construct_confirm_closehas been significantly modified. The translation for "Close multiple terminals?" was broken and a few translatable texts were added.