Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add external links to const. #2252

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Add external links to const. #2252

merged 3 commits into from
Jan 22, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Jan 21, 2022

Summary

  • Consolidates any external link into a const so we can edit it easier later.
  • Replaces <a href> with ExternalLink for the external links.
  • IntelliJ likes to tune in and correct some spelling in some comments 🤷🏼‍♂️

@fairlighteth fairlighteth requested review from a team January 21, 2022 18:34
src/custom/pages/Claim/InvestmentFlow/index.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

src/custom/pages/Claim/index.tsx Show resolved Hide resolved
@@ -33,6 +33,12 @@ import FooterNavButtons from './FooterNavButtons'
const GNO_CLAIM_APPROVE_MESSAGE = 'Approving GNO for investing in vCOW'
const USDC_CLAIM_APPROVE_MESSAGE = 'Approving USDC for investing in vCOW'

export const COW_LINKS = {
home: 'https://cow.fi/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not...will remove.

@fairlighteth
Copy link
Contributor Author

Addressed @alfetopito latest comments.

@fairlighteth fairlighteth merged commit 6499a5b into develop Jan 22, 2022
@alfetopito alfetopito deleted the claim-links branch February 1, 2022 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants