don't count reverted trades we don't display (#1480)

gnosis · Oct 5, 2020 · 6aff25f · 6aff25f
1 parent e09d686
commit 6aff25f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/components/OrdersWidget/index.tsx b/src/components/OrdersWidget/index.tsx
@@ -123,6 +123,11 @@ const OrdersWidget: React.FC<Props> = ({ displayOnly }) => {
     [allTrades, displayOnly],
   )
 
+  const settledAndNotRevertedTrades = useMemo(
+    () => trades.filter((trade) => trade && isTradeSettled(trade) && !isTradeReverted(trade)),
+    [trades],
+  )
+
   const tabList = useMemo<TabData<OrderTabs>[]>(
     () => [
       {
@@ -131,7 +136,7 @@ const OrdersWidget: React.FC<Props> = ({ displayOnly }) => {
       },
       {
         type: 'trades',
-        count: trades.length,
+        count: settledAndNotRevertedTrades.length,
       },
       {
         type: 'closed',
@@ -142,7 +147,7 @@ const OrdersWidget: React.FC<Props> = ({ displayOnly }) => {
       classifiedOrders.active.orders.length,
       classifiedOrders.active.pendingOrders.length,
       classifiedOrders.closed.orders.length,
-      trades.length,
+      settledAndNotRevertedTrades.length,
     ],
   )
 
@@ -301,11 +306,6 @@ const OrdersWidget: React.FC<Props> = ({ displayOnly }) => {
     [deleteOrders, forceOrdersRefresh, markedForDeletion, selectedTab, setClassifiedOrders],
   )
 
-  const settledAndNotRevertedTrades = useMemo(
-    () => trades.filter((trade) => trade && isTradeSettled(trade) && !isTradeReverted(trade)),
-    [trades],
-  )
-
   const {
     filteredData: filteredTrades,
     handlers: { handleSearch: handleTradesSearch, clearFilters: clearTradesFilters },