Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

fix networkOrDefault type and typo #1528

Merged
merged 2 commits into from
Oct 13, 2020
Merged

fix networkOrDefault type and typo #1528

merged 2 commits into from
Oct 13, 2020

Conversation

W3stside
Copy link
Contributor

Fixes broken line using buyToken instead of receiveToken and assigns Network type to networkIdOrDefault inside useWalletConnection

@W3stside W3stside requested a review from Velenir October 13, 2020 12:49
@Velenir
Copy link
Contributor

Velenir commented Oct 13, 2020

Also change network type inside WalletInfo

@ghost
Copy link

ghost commented Oct 13, 2020

Travis automatic deployment:

@W3stside W3stside merged commit 9b22eef into release/v1.5 Oct 13, 2020
@W3stside W3stside deleted the small-fixes branch October 13, 2020 13:13
@W3stside W3stside mentioned this pull request Oct 13, 2020
@@ -6,7 +6,7 @@ import { BlockchainUpdatePrompt, WalletInfo } from 'api/wallet/WalletApi'

interface PendingStateObject extends WalletInfo {
pending: true
networkIdOrDefault: number
networkIdOrDefault: Network
Copy link
Contributor

@anxolin anxolin Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true @W3stside @Velenir ?

Being network a enum, we assume that this value won't ever be any other network.
Or the logic is setting mainnet if we are in an Unknown network?

export enum Network {
  Mainnet = 1,
  Ropsten = 3,
  Rinkeby = 4,
  Goerli = 5,
  Kovan = 42,
  xDAI = 100,
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants