Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

[Trivial] Fix clippy warning in balancer pool_storage #746

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

fleupold
Copy link
Contributor

☝️

not sure why @bh2smith's IDE doesn't seem to flag this issue.

Test Plan

Run clippy without complaints.

@fleupold fleupold requested a review from a team June 17, 2021 12:17
@fleupold fleupold changed the title [Trivial] Fix clippy warning in balance pool_storage [Trivial] Fix clippy warning in balancer pool_storage Jun 17, 2021
Copy link
Contributor

@vkgnosis vkgnosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this change but I think this might be your clippy being out of date. If there was a clippy warning CI would have prevented the PR from being merged.

Copy link
Contributor

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be a rust-analyzer thing. I don't think its clippy because CI didn't catch it, and neither did cargo clippy locally.

@fleupold
Copy link
Contributor Author

I believe this used to be a default lint in an older version of clippy: some more background rust-lang/rust-clippy#6726

@fleupold fleupold enabled auto-merge (squash) June 17, 2021 17:41
@fleupold fleupold merged commit 4a396e6 into main Jun 17, 2021
@fleupold fleupold deleted the delete_pools_clippy_fix branch June 17, 2021 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants