Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core-devs call.md #713

Merged
merged 20 commits into from
Aug 26, 2024
Merged

Update core-devs call.md #713

merged 20 commits into from
Aug 26, 2024

Conversation

vanshika-srivastava
Copy link
Contributor

What

  • (describe the changes in detail)

Refs

  • (this project accepts pull requests related to open issues)
  • (if suggesting a new feature or change, please discuss it in an issue first)
  • (if fixing a bug, there should be an issue describing it with steps to reproduce)
  • (only fixing a minor bug - broken link, typo - an issue is not needed)
  • (please link to the issue here)

0xarmagan and others added 19 commits July 29, 2024 13:11
Signed-off-by: zhoufanjin <shuangcui@live.cn>
Adding a warning about entering a withdrawal address at the key generation step in Wagyu. This idea comes after seeing multiple validators not paying attention to it recently and ending up having to update their withdrawal credential using Ethdo after which is not really easy for non technical people. This warning should hopefully prevent such cases in the future.
Fixing a warning that wasn't really exact, as updating a 0x00 withdrawal credential is also possible on an exited validator as well but is much more challenging because the node is most often offline.
Copy link
Contributor Author

@vanshika-srivastava vanshika-srivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in a new commit.

Copy link
Contributor

@zengzengzenghuy zengzengzenghuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@vanshika-srivastava vanshika-srivastava merged commit 028a5ab into main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants