Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Target attribute supported #48

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Feat: Target attribute supported #48

merged 1 commit into from
Sep 8, 2021
+99 −62

Conversation

cbrzn
Copy link
Collaborator

@cbrzn cbrzn commented Sep 7, 2021 •
edited
Loading

Changes proposed on this PR:

  • Setup function accepts target argument now and has validation
  • Question arbitrator is now oracle instead of the avatar
  • Tests updated accordingly
  • Name of package changed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1210865438

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1201452137: 0.0%
Covered Lines: 98
Relevant Lines: 98
💛 - Coveralls

auryn-macmillan
auryn-macmillan approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auryn-macmillan auryn-macmillan merged commit 94d8dcd into main Sep 8, 2021
@auryn-macmillan auryn-macmillan deleted the feat/target branch September 8, 2021 03:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbrzn @coveralls @auryn-macmillan