Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-636 refactor: use custom helper instead of delete #127

Merged
merged 1 commit into from
Dec 14, 2023
Merged

GSW-636 refactor: use custom helper instead of delete #127

merged 1 commit into from
Dec 14, 2023

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 14, 2023

Changed

  • seems like gnovm doesn't handle delete properly, for now use custom helper

@r3v4s r3v4s self-assigned this Dec 14, 2023
@notJoon notJoon merged commit 9f2f4bb into main Dec 14, 2023
@notJoon notJoon deleted the GSW-686-refactor-use-custom-helper-instead-of-delete branch December 14, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon