Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: terminate functions #214

Merged
merged 9 commits into from
May 2, 2024
Merged

hotfix: terminate functions #214

merged 9 commits into from
May 2, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Apr 30, 2024 •
edited
Loading

Fix

  1. due to gno's new terminating statement analysis, every function must be terminated(or at least panic)

  2. most of test cases has been changed to integration test for CI

@r3v4s r3v4s requested review from moul and notJoon April 30, 2024 09:20
@r3v4s r3v4s self-assigned this Apr 30, 2024
@r3v4s r3v4s changed the title fix: terminate functions hotfix: terminate functions Apr 30, 2024
@r3v4s r3v4s requested review from mconcat and removed request for moul April 30, 2024 11:32
@r3v4s r3v4s marked this pull request as draft April 30, 2024 11:32
@r3v4s
Copy link
Member Author

r3v4s commented Apr 30, 2024

WIP // testcase fix

@r3v4s r3v4s marked this pull request as ready for review May 2, 2024 06:16
@notJoon notJoon merged commit 0505710 into main May 2, 2024
1 check passed
@notJoon notJoon deleted the hotfix/terminate-functions branch May 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon