Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1045 #2: fix test cases + rounding error #216

Merged
merged 4 commits into from
May 3, 2024
Merged

GSW-1045 #2: fix test cases + rounding error #216

merged 4 commits into from
May 3, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented May 3, 2024

Fix

  1. reason for CI failing in GSW-1045 feat: update uint256 overflow calcualtion logic #215
  2. test cases
  3. rounding error

@r3v4s r3v4s requested review from notJoon and mconcat May 3, 2024 05:49
@r3v4s r3v4s self-assigned this May 3, 2024
@notJoon notJoon merged commit 1ede86b into main May 3, 2024
1 check passed
@notJoon notJoon deleted the GSW-1045-update-uint-256-overflow-calculation-logic branch May 3, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon