Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-358 feat: use caller address when calculation incentive id #84

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Nov 8, 2023

  • allow creating external incentive with same targetPath, rewardToken
    • includes caller address to support this

@r3v4s r3v4s requested review from notJoon and mconcat November 8, 2023 07:46
@r3v4s r3v4s self-assigned this Nov 8, 2023
@r3v4s r3v4s force-pushed the GSW-358-allow-creating-external-incentive-using-same-reward-token branch from aa295ce to 63dce52 Compare November 8, 2023 10:10
@r3v4s r3v4s marked this pull request as ready for review November 8, 2023 10:10
@notJoon notJoon merged commit 50e6ad8 into main Nov 8, 2023
@r3v4s r3v4s deleted the GSW-358-allow-creating-external-incentive-using-same-reward-token branch November 22, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants