Skip to content

Commit

Permalink
inspector: do not spin-wait while waiting for the initial connection
Browse files Browse the repository at this point in the history
Fixes: nodejs#28741

PR-URL: nodejs#28756
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
eugeneo authored and gntem committed Jul 27, 2019
1 parent e476fc8 commit ec1bd00
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -699,8 +699,7 @@ class NodeInspectorClient : public V8InspectorClient {

MultiIsolatePlatform* platform = env_->isolate_data()->platform();
while (shouldRunMessageLoop()) {
if (interface_ && hasConnectedSessions())
interface_->WaitForFrontendEvent();
if (interface_) interface_->WaitForFrontendEvent();
while (platform->FlushForegroundTasks(env_->isolate())) {}
}
running_nested_loop_ = false;
Expand Down

0 comments on commit ec1bd00

Please sign in to comment.