-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fuzzy-logic-toolkit.yaml: release 0.5.0 and 0.5.1 #452
Conversation
Thank you for updating the package. Just a couple of remarks and questions: Are you the original maintainer of the package that was hosted on sourceforge? It looks like the checksum doesn't match the tarball that is downloaded by the CI. Does the link point to the correct tarball? Or does the checksum need to be changed? It is a bit unusual to host the release tarballs in a different repository than the GitHub repository with the sources. That is assuming that the sources are here: https://github.com/lmarkowsky/fuzzy-logic-toolkit |
Thanks for your comments. Yes, I'm the original author and maintainer of the package, which has been hosted on Octave Forge since 2011. This is my first attempt to update the package in several years. The link points at the directory containing the tarball, not at the tarball itself. Perhaps that's the source of the discrepancy. I'm still getting the same checksum (for a local copy of the tarball) on my laptop. I'd definitely like to adapt my release process to the best current practice. Thanks for your comments, and I will follow your advice. |
Added section for release 0.5.0 of the fuzzy-logic-toolkit.
I've noticed that you tagged the release in the GitHub repository. So, I went ahead and updated the yaml file accordingly. If you don't mind, I'd like to merge this PR with these changes. Is that ok? |
Oops. Looks like we crossed. In the last commit the .yaml file ended up in the wrong directory. I've moved it to the correct one. Ok to merge? |
Good morning. Sure. Thank you. |
Is it correct now? I think I understand what I did wrong last time, but if not, please let me know. |
It's looking good to me. 👍 FYI: An announcement about the update is generated automatically on the Octave discourse forum shortly (approx. 30 minutes) after the update is merged in this repository. For the latest announcement, see: An additional side note: Built-in self tests (BISTs) can be run with Would you like to consider adding some tests to (some of) your functions? That would help to catch packaging, compatibility, or other issues more easily. |
Thank you! Yes, adding tests is definitely on my to-do list. Right now, there are embedded and standalone demos that have served as (not automatically run) tests, and adding tests is high on my to-do list. Thanks again for your help and advice. |
Added section for release 0.5.0 of the fuzzy-logic-toolkit.