Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check if version in package index matches version of installed package #454

Merged
merged 1 commit into from
May 16, 2024

Conversation

mmuetzel
Copy link
Member

Compare the package version in the .yaml file with the package version of the installed package (i.e., the DESCRIPTION file).
That might help to detect issues like the one in #451 earlier in the CI.

@cbm, @siko1056: This is untested as of now. Is the check correct? And could that be useful?

@mmuetzel mmuetzel merged commit 649c978 into gnu-octave:main May 16, 2024
2 checks passed
@siko1056 siko1056 added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels May 18, 2024
@siko1056
Copy link
Member

Thank you for this enhancement @mmuetzel .

I think an error would be appropriate too. If there is a version mismatch, this could be fixed before publishing the release.

The change itself seems to work looking at later package releases 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants