Skip to content

Commit

Permalink
chore: updating eslint config
Browse files Browse the repository at this point in the history
  • Loading branch information
gnugomez committed Dec 12, 2023
1 parent 6ecc819 commit 5db5534
Show file tree
Hide file tree
Showing 38 changed files with 1,501 additions and 1,051 deletions.
23 changes: 0 additions & 23 deletions .eslintrc.cjs

This file was deleted.

33 changes: 15 additions & 18 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,23 @@ on:
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
env:
TOKEN: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: 16

- name: Install pnpm
uses: pnpm/action-setup@v2
- uses: actions/checkout@v4
- run: corepack enable
- uses: actions/setup-node@v4
with:
version: 8

- name: Install dependencies
run: pnpm install

- name: Lint
run: pnpm lint
node-version: 18
cache: pnpm
- name: Print npm config
run: npm config list
- run: pnpm install
- run: pnpm lint

- name: Build
run: pnpm build
Expand All @@ -37,4 +34,4 @@ jobs:
uses: actions/upload-artifact@v2
with:
name: dist
path: dist/
path: dist/
1 change: 0 additions & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,3 @@ jobs:
asset_path: ./synco.crx
asset_name: synco.crx
asset_content_type: application/x-chrome-extension

2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
@gnugomez:registry=https://npm.pkg.github.com/
//npm.pkg.github.com/:_authToken=${PAT}
//npm.pkg.github.com/:_authToken=${TOKEN}
2 changes: 1 addition & 1 deletion PRIVACY_POLICY.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ We may update our Privacy Policy from time to time. Therefore, you are advised t

## Contact

If you have any questions or suggestions about our Privacy Policy, do not hesitate to contact me creating an issue in this repository.
If you have any questions or suggestions about our Privacy Policy, do not hesitate to contact me creating an issue in this repository.
12 changes: 7 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ This repository contains the source code of "synco" a chrome extension that lets
Is proudly made with [Vite](https://vitejs.dev/), [Vue 3](https://v3.vuejs.org/), [TypeScript](https://www.typescriptlang.org/), [Tailwind CSS](https://tailwindcss.com/)

## Features

- Multiple users per room (using peer to peer connections)
- Low latency commands (play, pause, seek) depending on the network conditions
- Lauch the extension from any website that contaians a video. ___Some websites are not supported yet such as netflix that blocks any extension that tries to interact with their video player.___
- Lauch the extension from any website that contaians a video. **_Some websites are not supported yet such as netflix that blocks any extension that tries to interact with their video player._**

## Things to improve
- [ ] This extension works completely peer to peer, however it needs to do a handshake with a server in order to know the other peers in the room. This handshake is done using firebase that is not ideal as it is a third party service. ___This can be improved by using a custom server that does the handshake and then the peers can communicate directly with each other.___

- [ ] This extension works completely peer to peer, however it needs to do a handshake with a server in order to know the other peers in the room. This handshake is done using firebase that is not ideal as it is a third party service. **_This can be improved by using a custom server that does the handshake and then the peers can communicate directly with each other._**
- [ ] Tranform this into a monorepo to separate the extension from the core that uses webRTC to sync the videos.
- [ ] Add a way to create a room with a custom name ___this indeed is actually possible, you just only need to join a room that doesn't exist yet.___
- [ ] Add a way to create a room with a custom name **_this indeed is actually possible, you just only need to join a room that doesn't exist yet._**
- [ ] Add a way to share the room link with your colleagues without having to remove the current room id funcionaity as may be used as well.

## Recommended IDE Setup
Expand All @@ -26,8 +28,8 @@ TypeScript cannot handle type information for `.vue` imports by default, so we r
If the standalone TypeScript plugin doesn't feel fast enough to you, Volar has also implemented a [Take Over Mode](https://github.com/johnsoncodehk/volar/discussions/471#discussioncomment-1361669) that is more performant. You can enable it by the following steps:

1. Disable the built-in TypeScript Extension
1) Run `Extensions: Show Built-in Extensions` from VSCode's command palette
2) Find `TypeScript and JavaScript Language Features`, right click and select `Disable (Workspace)`
1. Run `Extensions: Show Built-in Extensions` from VSCode's command palette
2. Find `TypeScript and JavaScript Language Features`, right click and select `Disable (Workspace)`
2. Reload the VSCode window by running `Developer: Reload Window` from the command palette.

## Customize configuration
Expand Down
8 changes: 4 additions & 4 deletions cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { defineConfig } from 'cypress'

export default defineConfig({
e2e: {
specPattern: 'cypress/e2e/**/*.{cy,spec}.{js,jsx,ts,tsx}',
baseUrl: 'http://localhost:4173',
},
e2e: {
specPattern: 'cypress/e2e/**/*.{cy,spec}.{js,jsx,ts,tsx}',
baseUrl: 'http://localhost:4173',
},
})
8 changes: 4 additions & 4 deletions cypress/e2e/example.cy.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// https://on.cypress.io/api

describe('My First Test', () => {
it('visits the app root url', () => {
cy.visit('/')
cy.contains('h1', 'You did it!')
})
it('visits the app root url', () => {
cy.visit('/')
cy.contains('h1', 'You did it!')
})
})
8 changes: 4 additions & 4 deletions cypress/e2e/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"extends": "@vue/tsconfig/tsconfig.dom.json",
"include": ["./**/*", "../support/**/*"],
"compilerOptions": {
"isolatedModules": false,
"target": "es5",
"lib": ["es5", "dom"],
"types": ["cypress"]
}
"types": ["cypress"],
"isolatedModules": false
},
"include": ["./**/*", "../support/**/*"]
}
7 changes: 7 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import antfu from '@antfu/eslint-config'

export default antfu(
{
formatters: true,
},
)
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"name": "synco",
"name": "@gnugomez/synco",
"type": "module",
"version": "1.2.1",
"private": true,
"type": "module",
"repository": "gnugomez/synco",
"scripts": {
"dev": "vite",
"build": "run-p type-check build-only",
Expand All @@ -12,7 +13,7 @@
"test:e2e:dev": "start-server-and-test 'vite dev --port 4173' http://localhost:4173 'cypress open --e2e'",
"build-only": "vite build",
"type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false",
"lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore",
"lint": "eslint .",
"format": "prettier --write src/"
},
"dependencies": {
Expand All @@ -28,7 +29,7 @@
"webextension-polyfill": "^0.10.0"
},
"devDependencies": {
"@antfu/eslint-config": "^0.39.3",
"@antfu/eslint-config": "^2.4.4",
"@crxjs/vite-plugin": "2.0.0-beta.17",
"@iconify/json": "^2.2.72",
"@rushstack/eslint-patch": "^1.2.0",
Expand All @@ -38,15 +39,14 @@
"@types/node": "^18.16.10",
"@types/webextension-polyfill": "^0.10.2",
"@vitejs/plugin-vue": "^4.2.3",
"@vue/eslint-config-prettier": "^7.1.0",
"@vue/eslint-config-typescript": "^11.0.3",
"@vue/test-utils": "^2.3.2",
"@vue/tsconfig": "^0.4.0",
"autoprefixer": "^10.4.14",
"cypress": "^12.12.0",
"eslint": "^8.41.0",
"eslint": "^8.55.0",
"eslint-plugin-cypress": "^2.13.3",
"eslint-plugin-vue": "^9.13.0",
"eslint-plugin-format": "^0.0.1",
"jsdom": "^22.0.0",
"npm-run-all": "^4.1.5",
"postcss": "^8.4.31",
Expand Down
Loading

0 comments on commit 5db5534

Please sign in to comment.