Fixes for tests with weak pointers in notification observers.

gnustep · Dec 27, 2024 · 40bae20 · 40bae20
1 parent f6d47ba
commit 40bae20
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -5,8 +5,10 @@
 	* Source/GSPrivate.h:
 	* Source/NSConcreteHashTable.m:
 	* Source/NSConcretePointerFunctions.h:
+	* Source/NSMessagePort.m:
 	* Source/NSNotificationCenter.m:
 	* Source/NSObject.m:
+	* Source/NSSocketPort.m:
 	* Source/ObjectiveC2/GNUmakefile:
 	* Source/ObjectiveC2/README:
 	* Source/ObjectiveC2/weak.m:

diff --git a/Source/NSMessagePort.m b/Source/NSMessagePort.m
@@ -1705,8 +1705,9 @@ - (oneway void) release
         {
           NSMapRemove(messagePortMap, (void*)name);
 	}
+      [self retain];
       M_UNLOCK(messagePortLock);
-      [self dealloc];
+      [super release];
     }
   else
     {

diff --git a/Source/NSObject.m b/Source/NSObject.m
@@ -2486,6 +2486,10 @@ - (Class) originalClass
     }
   return c;
 }
+- (NSUInteger) retainCount
+{
+  return 0;	// So that gs_weak_load() knows the object was deallocated
+}
 - (void) logZombie: (SEL)selector
 {
   GSLogZombie(self, selector);

diff --git a/Source/NSSocketPort.m b/Source/NSSocketPort.m
@@ -2474,8 +2474,9 @@ - (oneway void) release
 	{
 	  NSMapRemove(thePorts, host);
 	}
+      [self retain];
       M_UNLOCK(tcpPortLock);
-      [self dealloc];
+      [super release];
     }
   else
     {

diff --git a/Tests/base/NSConnection/basic.m b/Tests/base/NSConnection/basic.m
@@ -6,13 +6,14 @@
 
 int main()
 {
-  NSAutoreleasePool   *arp = [NSAutoreleasePool new];
-  id testObject = nil;
+  NSAutoreleasePool	*arp = [NSAutoreleasePool new];
+  id 			testObject = nil;
+
   test_alloc(@"NSConnection");
   testObject = [NSConnection new];
-  test_NSObject(@"NSConnection",[NSArray arrayWithObject:testObject]); 
+  test_NSObject(@"NSConnection", [NSArray arrayWithObject: testObject]); 
   testObject = [NSConnection defaultConnection];
-  PASS(testObject != nil && [testObject isKindOfClass:[NSConnection class]],
+  PASS(testObject != nil && [testObject isKindOfClass: [NSConnection class]],
        "NSConnection +defaultConnection works");
 
   [arp release]; arp = nil;