Warning Fix #199
Merged
Warning Fix #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expose the method in its header, but we don't we don't know if it has it private. In case it is a GS extension, perhaps we should name it private with an _.
fredkiefer
reviewed
Sep 17, 2023
Source/GNUmakefile
Outdated
| @@ -684,19 +684,6 @@ GSXibElement.h \ | |||
| GSXibLoading.h \ | |||
| GSXibKeyedUnarchiver.h \ | |||
| GSHelpAttachment.h \ | |||
There was a problem hiding this comment.
You should remove the trailing backslash as well.
There was a problem hiding this comment.
it is convenient to add later, but yes, cleaner. Removed.
fredkiefer
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catched some - not all, but catched some - done with Greg.