Add APPKIT_EXPORT_CLASS, APPKIT_EXPORT annotations #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GS* classes and methods are used by the ColorPicker or Printing bundles. That means that they are referenced from an external module. For this module to be able to resolve these symbols, on Windows, they need to be exported. This commit adds `APPKIT_EXPORT_CLASS` and `APPKIT_EXPORT` annotations, allowing ColorPickers to compile on Windows.
fredkiefer
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GS* classes and methods are used by the ColorPicker or Printing bundles. That means that they are referenced from an external module. For this module to be able to resolve these symbols, on Windows, they need to be exported.
This commit adds
APPKIT_EXPORT_CLASSandAPPKIT_EXPORTannotations, allowing ColorPickers and Printing bundles to compile on Windows using a native (non-mingw) toolchain.