implement integerValue method in NSSliderCell #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the superclass method integerValue: method in NSCell uses the _object_value to retrieve the result, but the implementation of setObjectValue: in NSSliderCell sets _value. So integerValue: needs to return _value.
fredkiefer
approved these changes
Sep 24, 2024
|
Sadly it did not happen so I merge without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you call setIntegerValue: method on an NSSliderCell, it calls the superclass method in NSCell, which then calls setObjectValue:. The implementation of setObjectValue: in NSSliderCell sets the _value ivar. The problem is, when you call integerValue: it calls the superclass method in NSCell, which returns a value based on the _object_value ivar, which has not been set.
By implementing the integerValue: method directly in NSSliderCell, this will return the correct value.