Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue with NSCell flags not getting set properly #300

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix Issue with NSCell flags not getting set properly #300

merged 2 commits into from
Oct 8, 2024

Conversation

johnathan-becker
Copy link
Contributor

This PR fixes an issue where NSCellType (enum) and NSLineBreakMode (struct) were not being properly respected in MSYS2 as bit field members thus making a 32bit union 44 bytes.

gcasa
gcasa reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@gcasa gcasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may need to test these to make sure that older .gorm files are not effected by this change as it could alter the bit layout that is read/written.

@johnathan-becker
Copy link
Contributor Author

I may need to test these to make sure that older .gorm files are not effected by this change as it could alter the bit layout that is read/written.

That is no problem. I do not expect any problems but please feel free to run test. Better safe than sorry.

@fredkiefer fredkiefer merged commit 4d50863 into gnustep:master Oct 8, 2024
3 checks passed
@gcasa
Copy link
Member

gcasa commented Oct 8, 2024

I may need to test these to make sure that older .gorm files are not effected by this change as it could alter the bit layout that is read/written.

That is no problem. I do not expect any problems but please feel free to run test. Better safe than sorry.

Looks okay. I ran a few manual tests. Thanks.

@johnathan-becker johnathan-becker deleted the FIX_NSCELL_ISSUES branch October 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcasa gcasa gcasa left review comments

@fredkiefer fredkiefer Awaiting requested review from fredkiefer fredkiefer is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnathan-becker @gcasa @fredkiefer