Fix issue with nsmenu items blocking the GUI #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredkiefer
requested changes
Nov 11, 2024
johnathan-becker
force-pushed
the
johnb-double-click
branch
from
2abd852
to
a1850e1
Compare
|
@fredkiefer I am not sure why the pipelines are failing I am getting the message |
|
Skipping most of the tests is normal in the pipeline. Maybe we should add a step to download and compile back here? But then I have no idea, how your change could affect that. |
fredkiefer
approved these changes
Nov 14, 2024
|
I found and fixed the reason why the NSBezierPath test failed. If you rebase it should be fixed for you as well. |
johnathan-becker
force-pushed
the
johnb-double-click
branch
from
a1850e1
to
29e4d90
Compare
|
@fredkiefer I have rebased and all checks have passed now! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes an issue where when you click item an NSMenuView item you have a frozen UI until you double click a second time, ending the loop.