Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix snap name #2349

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: fix snap name #2349

merged 1 commit into from
Nov 13, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 13, 2024

I feel (I didn't test it) like I should follow the same configuration as goreleaser:

https://github.com/goreleaser/goreleaser/blob/efe8b7089e55ac2de54238b699f2ba18cc339d5f/.goreleaser.yaml#L353C12-L354C85

@ldez ldez added this to the unreleased milestone Nov 13, 2024
@ldez ldez added bug and removed enhancement labels Nov 13, 2024
@ldez ldez requested a review from dmke November 13, 2024 14:27
dmke
dmke approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this, but that looks reasonable.

@ldez ldez enabled auto-merge (squash) November 13, 2024 14:48
@ldez ldez merged commit 15af107 into go-acme:master Nov 13, 2024
7 checks passed
@ldez ldez deleted the fix/snap-name branch November 13, 2024 14:52
@ldez ldez modified the milestones: unreleased, v4.20 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/infrastructure bug
Milestone
v4.20
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @dmke