Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

integration of RegisterMessageReceiveFilter work #135

Open
bnfinet opened this issue May 30, 2021 · 1 comment
Open

integration of RegisterMessageReceiveFilter work #135

bnfinet opened this issue May 30, 2021 · 1 comment

Comments

@bnfinet
Copy link
Contributor

bnfinet commented May 30, 2021

A while back I added the feature RegisterMessageReceiveFilter to my fork...
https://github.com/bnfinet/go-chat-bot/blob/master/cmd.go#L282-L296

This filter operation is conducted before command interpretation and execution. This allows for plugins to be created with a generalized allow/disallow and RBAC of commands based on proto/server/channel/user criteria.

Instead of opening a PR I decided to start with an issue to see if this is worthy of inclusion. If so, I'll start from the current master in this repo and (non git) cherry pick the changes, since this work is mostly from a few years back.

Thanks for your consideration.

5271579

@fabioxgn
Copy link
Member

fabioxgn commented Jun 1, 2021

Hi @bnfinet this change looks good to me, if you'd like to send a PR, please do so and I'll merge it. Thanks.

bnfinet added a commit to bnfinet/go-chat-bot that referenced this issue Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants