Add ChannelData to Cmd #41
Conversation
This stores a bit more info than just the channel name; in addition you get the protocol (irc, slack, telegram), server host, and whether the channel is a private chat or a public channel. As of now this is a drop-in replacement without BC breaks.
slack/slack.go
Outdated
| @@ -67,7 +69,14 @@ Loop: | |||
| readBotInfo(api) | |||
| case *slack.MessageEvent: | |||
| if !ev.Hidden && !ownMessage(ev.User) { | |||
| b.MessageReceived(ev.Channel, ev.Text, extractUser(ev.User)) | |||
| ti, _ := api.GetTeamInfo() | |||
There was a problem hiding this comment.
This team info could be obtained after connecting to slack to avoid making a request for each received msg couldn't it?
There was a problem hiding this comment.
You're absolutely right - will fix!
|
I see I have left out the proper info for Slack channels, please hold off on merging this PR. |
|
Added some code to get the proper channel name for Slack channels, rather than just some Cxxxxxx code. I'm not 100% sure if this is the most effective way - am I not pissing away memory by storing / retrieving the Channels this way? Should or shouldn't I use pointers? Some guidance would be nice, since I'm still new to Go. :) While adding this code, I saw that |
|
@doenietzomoeilijk You are right, the extractUser could be cached, if you are willing to change it will be a nice optimization. And I don't think this list of channels would be an issue to be stored, go uses so little memory that you must try harded than this for it to be an issue 🤣 Thanks for your PR, I'll merge it and deploy this new changes to my bot to test it out. |
This stores a bit more info than just the channel name; in addition you get the protocol (irc, slack, telegram), server host, and whether the channel is a private chat or a public channel.
As of now this is a drop-in replacement without BC breaks.
Also relevant to #6 and #37 .