set a new route ctx if rctx is nil #878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurineydachin
approved these changes
Dec 6, 2023
AndreiOslin
approved these changes
Dec 6, 2023
VojtechVitek
reviewed
Dec 7, 2023
Comment on lines
+58
to
+60
| if rctx == nil { | ||
| rctx = chi.NewRouteContext() | ||
| } |
There was a problem hiding this comment.
Should we move this check above line 54 and replace if rctx != nil?
|
Hey @shedyfreak, @yurineydachin, @AndreiOslin, I'm just checking back on this PR and I wonder -- how do you trigger the #839 panic? Under what circumstance is the route context nil? Might be helpful to provide a test case for this too. @shedyfreak what's your thoughts on #878 (comment) ? |
|
It looks like #841 was submitted first and has a test case too. I'll follow up there. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to solve #839