Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect comment about routing #887

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

jtams
Copy link
Contributor

@jtams jtams commented Dec 20, 2023

In the chi.go file there are examples of routing behaviors. One comment was meant to demonstrate how other routes can match wildcard routes, but there was a typo that made it incorrect:

// "/page/{other}/index" also matches "/page/intro/latest"

Resolves #879

The comment was meant to demonstrate how non-wildcard routes can match
wilecard routes, but there was likely a typo that made it incorrect.
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechVitek VojtechVitek merged commit df0303d into go-chi:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Route Matching Comment in chi.go
2 participants