[compress] Create compress writer only in case the content is compressible #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neurostep
force-pushed
the
Neurostep/compression-middleware-refactor-writer-wrapper
branch
from
625b26f to
e57b2d6
Compare
|
Tested this PR with both |
|
@VojtechVitek Anything I can do to move this forward? I would love to see an end to this issue, let me know if the PR needs more updates 🙏 |
|
Hey, I'll get back to this once I have some free time. I'm swamped with product work now :) |
|
@VojtechVitek Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, there was an attempt to fix the potential memory leak in the
compressmiddleware. For details, check the following PR: #919Although the fix worked for that particular case, it introduced a bug (#923) that caused the unnecessary write of the gzip header even in case the content is not compressible.
After discussing this with @VojtechVitek it was decided to try to create a compressed writer only when the content is compressible.
This PR also adds more test cases to test the raw output in the case of no compression to make sure we are not changing the output.
Related