Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt add-json-iterator-with-build-tags #11

Closed
wants to merge 3 commits into from
Closed

opt add-json-iterator-with-build-tags #11

wants to merge 3 commits into from

Conversation

chyroc
Copy link

@chyroc chyroc commented Jan 29, 2018

No description provided.

@chyroc
Copy link
Author

chyroc commented Jan 29, 2018

@VojtechVitek More humane and beautiful way to add json-iterator by go build -tags=jsoniter ., and then I will close #9, I hope to pass the review, thank you

Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tags! Nice and elegant 👍

Let me test this PR once I have some spare time. Any help from the community would be appreciated too!

@chyroc
Copy link
Author

chyroc commented Jan 31, 2018

Thank you very much for your approval. I tested this change in my own project (via the init function in different files) and the result is correct. I do not know what happened to your test result. If there are any problems, please correct me.

@VojtechVitek
Copy link
Contributor

@chyroc I haven't had chance to test this out yet. But I will. 👍
I'm very busy recently, so please be patient, it might take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants