Replace tag map with thread safe sync.map #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Aug 21, 2021
scheduler.go
Outdated
| if s.tags != nil { | ||
| s.TagsUnique() | ||
| } | ||
| s.TagsUnique() |
There was a problem hiding this comment.
We only want to set the tags to unique if they were originally set on the scheduler. So this should probably still have a if check to say if not false then set to an new empty sync map. Am I missing something with how this map works or anything?
There was a problem hiding this comment.
Ah, I see, the purpose of this originally was to reinstantiate the tag map to clear out the tags. Now that it is using a sync.Map, it would need to go through and delete the items within.
There was a problem hiding this comment.
Fixed and verified with TDD.
JohnRoesler
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR replaces that
uniqueTagmap with the sync.Map struct which allows safe concurrent operations against the map. Before this, scheduled jobs that executed on the same schedule were prone to causing a "concurrent map" panic.Have you included tests for your changes?
Tests have been updated to properly use the sync.map.
Notes
This change should produce a no-op, just fixes the potential panic from jobs scheduled at the same time that require
uniqueTags.