actions: install-dpkg: Implement action to install local Debian packages #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
69ff4e0
to
e764a9d
Compare
sjoerdsimons
requested changes
Jun 25, 2020
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
e764a9d
to
eb4cf97
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
eb4cf97
to
2cdd04b
Compare
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
2cdd04b
to
493a65a
Compare
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
493a65a
to
b38e470
Compare
obbardc
requested review from
sjoerdsimons
and removed request for
sjoerdsimons
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
b38e470
to
c39490e
Compare
The apt commands will also be used by the install-dpkg wrapper, prepare for this by abstracting the generic apt commands into a wrapper class. Also create a wrapper base class to be able to abstract common action commands into generic functions. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
The install-dpkg action allows local .deb packages to be installed using the apt command, much like the apt action but for local packages rather than for packages retrieved from remote apt repositories. Resolves: go-debos#157 Closes: go-debos#165 Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/action-apt-local-file
branch
from
c39490e
to
487fd18
Compare
sjoerdsimons
requested changes
Jan 13, 2024
| @@ -41,6 +41,7 @@ Some of the actions provided by debos to customize and produce images are: | |||
| * download: download a single file from the internet | |||
| * filesystem-deploy: deploy a root filesystem to an image previously created | |||
| * image-partition: create an image file, make partitions and format them | |||
| * install-dpkg: install packages and their dependencies from local 'deb' files | |||
There was a problem hiding this comment.
install-dpkg is rather weird for an action that install a .deb using apt :p Why not call it install-deb :)
| Dependencies will be satisfied first from the `packages` list (i.e. locally | ||
| available packages) and then from the target's configured apt repositories. If | ||
| `deps` is set to false, dependencies will not be installed and an error will be | ||
| thrown. TODO: check this |
|
|
||
| - action: install-dpkg | ||
| description: Install Debian package from url | ||
| origin: bmap-tools-pkg |
There was a problem hiding this comment.
no packages listen in this example?
|
|
||
| Optional properties: | ||
|
|
||
| - origin -- reference to named file or directory. Defaults to recipe directory. |
There was a problem hiding this comment.
origin shouldn't be a named file or a directory but an origin (which i think has some documentation elsewhere)
Comment on lines
+93
to
+94
| a := &InstallDpkgAction{Update: true} | ||
| return a |
There was a problem hiding this comment.
Suggested change
| a := &InstallDpkgAction{Update: true} | |
| return a | |
| return &InstallDpkgAction{Update: true} |
| packages = append(packages, matches...) | ||
| } | ||
| } else { | ||
| packages = append(packages, origin) |
There was a problem hiding this comment.
what if the user passed a Package list?
| // check for duplicates after globbing | ||
| for j := idx + 1; j < len(packages); j++ { | ||
| if packages[j] == pkg { | ||
| return fmt.Errorf("duplicate package found: %s", pkg) |
There was a problem hiding this comment.
why not dedup the list rather then erroring out ?
| } | ||
| } | ||
|
|
||
| log.Printf("Installing %s", pkg) |
There was a problem hiding this comment.
you're printing Installing; but there is a bunch of stuff and commands being run before things are actually installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install-dpkg action allows local .deb packages to be installed using the apt command, much like the apt action but for local packages rather than for packages retrieved from remote apt repositories.
Resolves: #157
Closes: #165