actions: overlay: Check source exists during RecipeDir during verification #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
sjoerdsimons
requested changes
Apr 28, 2022
tryBuild failed: |
obbardc
changed the title
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
12bd81a
to
9a89ebe
Compare
…ation If an overlay (with a source from the recipe directory which is unlikely to change during execution) doesn't exist, the recipe errors out during execution. Let's check early if the overlay exists on the host filesystem inside the recipe directory. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Since the overlay-non-existent-destination test now also checks for a non-existent source, let's rename the test to be overlay to better describe the test contents. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
9a89ebe
to
add9a02
Compare
sjoerdsimons
requested changes
Jan 13, 2024
| @@ -1,6 +1,12 @@ | |||
| architecture: amd64 | |||
|
|
|||
| actions: | |||
| # This overlay action is expected to error out here because the source | |||
| # doesn't exist in the recipe directory. | |||
There was a problem hiding this comment.
so now the next part is no longer tested because this one already errored out right or am i missing something?
There was a problem hiding this comment.
would it make sense to do the rename in the same commit where you changed it ? also this seems to only delete not add the new name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an overlay coming from the recipe directory doesn't
exist, the recipe exits during execution. Let's check
early if the overlay exists on the host filesystem.