action: Remove *BaseAction.LogStart() function #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LogStart() function was manually called at the start of each Run() function for each action to print the initial log line for each action (to print the action name/description). Move this logic to the main loop so that we don't need to reply on an action to remember to call this function. Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
obbardc
force-pushed
the
wip/obbardc/remove-LogStart
branch
from
bc203b1
to
f737e5c
Compare
|
It's been a long day, yet I'm struggling to see how this MR is different from the one I've opened. |
Sorry, long day for me also. Happy to close this and let you continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LogStart() function was manually called at the start of each Run() function for each action to print the initial log line for each action (to print the action name/description). Move this logic to the main loop so that we don't need to reply on an action to remember to call this function.
(cc @evelikov)