Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/dap: Add launch request support for stackTraceDepth arg #2099

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

polinasok
Copy link
Collaborator

Introduces a new struct type to track all launch arguments.
Reworks the test code to reduce duplicate boilerplate request sequences.

Updates #1515

Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekparker derekparker merged commit 717e268 into go-delve:master Jul 8, 2020
abner-chenc pushed a commit to loongson/delve that referenced this pull request Mar 1, 2024
…elve#2099)

* service/dap: Support stackTraceDepth launch argument

* Respond to review comments

* Make DeepSource happy

Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants