service/dap: support clearing breakpoints and setting breakpoint conditions #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
approved these changes
Oct 1, 2020
service/dap/server.go
Outdated
| if err != nil { | ||
| s.log.Error("ERROR:", err) | ||
| s.log.Error("ERROR: ", err) |
There was a problem hiding this comment.
I took a look at the SetBreakpointsRequest specification and it seems to me that when there is an error the adapter can return verified == false and set the message field to explain why the breakpoint couldn't be verified, wouldn't that be better?
I'm approving this, this is just something to consider.
polinasok
commented
Oct 2, 2020
service/dap/server.go
Outdated
| if err != nil { | ||
| s.log.Error("ERROR:", err) | ||
| s.log.Error("ERROR: ", err) |
| // and clear all previous breakpoints in that source." The simplest way is | ||
| // to clear all and then set all. | ||
| // | ||
| // TODO(polina): should we optimize this as follows? |
There was a problem hiding this comment.
Do you have an opinion here? (This was a user request).
There was a problem hiding this comment.
I'm skeptical that the performance difference would be visible. Maybe when the adapter was javascript talking to delve using our API over laggy network.
abner-chenc
pushed a commit
to loongson/delve
that referenced
this pull request
Mar 1, 2024
…itions (go-delve#2188) * Support clearing breakpoints and setting conditions * Return unverified breakpoints with errors Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1515