Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove redundant err declarations #3855

Merged

Conversation

alexandear
Copy link
Contributor

The PR removes redundant var err error lines across the project.

@aarzilli
Copy link
Member

aarzilli commented Nov 7, 2024

I'm not sure why but the windows/amd64 build seems to fail. I've tried rerunning it and it failed in the same way. I've tried running it without this PR and it does not.

Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've looked into the error and it doesn't seem to be our problem, it's caused by a call to ReadProcessMemory failing to complete properly which doesn't sound like anything that could have been caused by recent changes.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 091e553 into go-delve:master Nov 12, 2024
2 checks passed
@alexandear alexandear deleted the refactor/redundant-var-err-decl branch November 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants