-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: print a message when the debugee process exits #3870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client already prints something on exit. Is this because of headless instances?
Hello, yeap the main use case is for headless instances and when |
Then it needs to work like the |
Thanks, let me check those out. |
e65b613
to
1580380
Compare
Hi @aarzilli, I have updated the PR with your suggestion. Hopefully I did not misunderstand your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1580380
to
25baac3
Compare
25baac3
to
e96d6bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This MR makes a simple change to print a message when the debugee process exits. This is useful when debugging a process that is abruptly killed (for e.g. OOM). Currently, it will just look like the process has "hung".