Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: removing of dlvbin is not needed #3875

Merged
merged 1 commit into from
Dec 9, 2024
Merged

tests: removing of dlvbin is not needed #3875

merged 1 commit into from
Dec 9, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Dec 9, 2024 •
edited
Loading

This PR removes useless os.Remove(dlvbin) in tests.

protest.GetDlvBinary calls getDlvBinInternal which creates dlv.exe inside the temporary directory from t.TempDir(). And T.TempDir function automatically removes the returned directory.

aarzilli
aarzilli approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekparker
derekparker approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 84c99e5 into go-delve:master Dec 9, 2024
2 checks passed
@alexandear alexandear deleted the tests-useless-os-remove branch December 9, 2024 17:56
@BrewTestBot BrewTestBot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekparker derekparker derekparker approved these changes

@aarzilli aarzilli aarzilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @aarzilli @derekparker