Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve BCE #2

Merged
merged 4 commits into from
Dec 24, 2021
Merged

feat: improve BCE #2

merged 4 commits into from
Dec 24, 2021

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 24, 2021 •
edited
Loading 

name                   old time/op    new time/op    delta
ClickHouse128/16-12      9.25ns ± 1%    9.09ns ± 1%   -1.75%  (p=0.000 n=14+14)
ClickHouse128/64-12      15.9ns ± 1%    15.7ns ± 1%   -1.09%  (p=0.000 n=14+14)
ClickHouse128/256-12     58.4ns ± 1%    45.8ns ± 1%  -21.62%  (p=0.000 n=15+15)
ClickHouse128/1024-12     186ns ± 1%     134ns ± 1%  -27.72%  (p=0.000 n=15+14)
ClickHouse64-12           183ns ± 1%     137ns ± 1%  -25.17%  (p=0.000 n=14+15)
CityHash32-12             372ns ± 1%     372ns ± 1%     ~     (p=0.889 n=12+14)
CityHash64-12             193ns ± 0%     147ns ± 1%  -24.09%  (p=0.000 n=15+13)
CityHash128-12            199ns ± 1%     151ns ± 0%  -24.40%  (p=0.000 n=14+12)
CityHash64Small-12       4.45ns ± 1%    4.22ns ± 1%   -5.17%  (p=0.000 n=14+13)
CityHash128Small-12      10.7ns ± 0%    10.7ns ± 2%     ~     (p=0.581 n=14+15)
[Geo mean]               53.7ns         46.3ns       -13.87%

name                   old speed      new speed      delta
ClickHouse128/16-12    1.73GB/s ± 1%  1.76GB/s ± 1%   +1.78%  (p=0.000 n=14+14)
ClickHouse128/64-12    4.02GB/s ± 2%  4.07GB/s ± 1%   +1.22%  (p=0.000 n=15+14)
ClickHouse128/256-12   4.38GB/s ± 1%  5.59GB/s ± 1%  +27.57%  (p=0.000 n=15+15)
ClickHouse128/1024-12  5.51GB/s ± 1%  7.62GB/s ± 1%  +38.34%  (p=0.000 n=15+14)
ClickHouse64-12        5.60GB/s ± 1%  7.48GB/s ± 1%  +33.72%  (p=0.000 n=15+15)
CityHash32-12          2.75GB/s ± 1%  2.75GB/s ± 1%     ~     (p=0.940 n=12+14)
CityHash64-12          5.30GB/s ± 0%  6.98GB/s ± 1%  +31.75%  (p=0.000 n=15+13)
CityHash128-12         5.14GB/s ± 1%  6.79GB/s ± 0%  +32.27%  (p=0.000 n=14+12)
CityHash64Small-12     2.25GB/s ± 1%  2.37GB/s ± 1%   +5.45%  (p=0.000 n=14+13)
CityHash128Small-12     934MB/s ± 1%   931MB/s ± 1%     ~     (p=0.561 n=14+15)
[Geo mean]             3.29GB/s       3.82GB/s       +16.12%

@tdakkota
feat: eliminate BCEs in weakHash32SeedsByte
b2ad54e 
Benchstat result:

name              old time/op    new time/op    delta
ClickHouse128-12     186ns ± 0%     148ns ± 1%  -20.54%  (p=0.000 n=23+21)

name              old speed      new speed      delta
ClickHouse128-12  5.50GB/s ± 0%  6.93GB/s ± 1%  +25.88%  (p=0.000 n=24+21)
@tdakkota
fix: use LittleEndian.Uint64 directly
8e81405 
name              old time/op    new time/op    delta
ClickHouse128-12     148ns ± 1%     139ns ± 1%  -5.93%  (p=0.000 n=21+25)

name              old speed      new speed      delta
ClickHouse128-12  6.93GB/s ± 1%  7.36GB/s ± 1%  +6.29%  (p=0.000 n=21+25)
@tdakkota
test(ch128): benchmark multiple payload sizes
e0df8dd
@tdakkota
feat: improve BCE in loop
7195a37 
name                   old time/op    new time/op    delta
ClickHouse128/16-12      9.31ns ± 1%    9.10ns ± 0%  -2.24%  (p=0.000 n=25+25)
ClickHouse128/64-12      15.8ns ± 1%    15.8ns ± 0%    ~     (p=0.659 n=21+22)
ClickHouse128/256-12     46.9ns ± 0%    46.0ns ± 1%  -2.04%  (p=0.000 n=25+23)
ClickHouse128/1024-12     140ns ± 1%     135ns ± 0%  -3.52%  (p=0.000 n=22+21)

name                   old speed      new speed      delta
ClickHouse128/16-12    1.72GB/s ± 1%  1.76GB/s ± 0%  +2.29%  (p=0.000 n=25+25)
ClickHouse128/64-12    4.06GB/s ± 1%  4.06GB/s ± 1%    ~     (p=0.848 n=22+22)
ClickHouse128/256-12   5.46GB/s ± 0%  5.57GB/s ± 1%  +2.09%  (p=0.000 n=25+23)
ClickHouse128/1024-12  7.29GB/s ± 1%  7.56GB/s ± 0%  +3.65%  (p=0.000 n=22+21)
@codecov
Copy link

codecov bot commented Dec 24, 2021 •
edited
Loading

Codecov Report

Merging #2 (7195a37) into main (2732b10) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          603       603           
=========================================
  Hits           603       603
Impacted Files Coverage Δ
128.go 100.00% <100.00%> (ø)
64.go 100.00% <100.00%> (ø)
ch_128.go 100.00% <100.00%> (ø)
ch_64.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2732b10...7195a37. Read the comment docs.

@ernado ernado merged commit 44961f0 into go-faster:main Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdakkota @ernado