Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reference buffer for key if decoder is buffered #63

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

Subsequent reads will change buffer and so, may overwrite the key.
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #63 (ffea80f) into main (aad4d90) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2416      2422    +6     
=========================================
+ Hits          2416      2422    +6     
Impacted Files Coverage Δ
dec_obj.go 100.00% <100.00%> (ø)
dec_obj_iter.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad4d90...ffea80f. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review July 14, 2022 20:52
@ernado ernado merged commit 0dc2de2 into go-faster:main Jul 14, 2022
@tdakkota tdakkota deleted the fix/object-reading branch July 14, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants