Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass offset to unexpected byte error #69

Merged
merged 10 commits into from
Jan 20, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b948aed) compared to base (2f8261b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b948aed differs from pull request most recent head cc57d4d. Consider uploading reports for the commit cc57d4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #69    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           37        38     +1     
  Lines         2610      2840   +230     
==========================================
+ Hits          2610      2840   +230     
Impacted Files Coverage Δ
dec_int.go 100.00% <ø> (ø)
w_int.go 100.00% <ø> (ø)
dec.go 100.00% <100.00%> (ø)
dec_arr.go 100.00% <100.00%> (ø)
dec_arr_iter.go 100.00% <100.00%> (ø)
dec_bool.go 100.00% <100.00%> (ø)
dec_capture.go 100.00% <100.00%> (ø)
dec_error.go 100.00% <100.00%> (ø)
dec_float.go 100.00% <100.00%> (ø)
dec_int.gen.go 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the feat/better-errors branch 3 times, most recently from a68529a to bb7141a Compare January 20, 2023 02:04
@tdakkota tdakkota marked this pull request as ready for review January 20, 2023 03:25
@tdakkota tdakkota force-pushed the feat/better-errors branch 2 times, most recently from b948aed to 4923cfa Compare January 20, 2023 03:51
Using noescape hack may lead to use-after-free error.
Error returned by `strconv.ParseFloat` may refer to
allocated slice.
@tdakkota tdakkota merged commit 75ecdde into go-faster:main Jan 20, 2023
@tdakkota tdakkota deleted the feat/better-errors branch January 20, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant