Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle end of the number correctly #70

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@tdakkota tdakkota marked this pull request as draft January 23, 2023 08:45
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5127e9c) compared to base (75ecdde).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5127e9c differs from pull request most recent head 03c1e5e. Consider uploading reports for the commit 03c1e5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #70    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        39     +1     
  Lines         2840      3055   +215     
==========================================
+ Hits          2840      3055   +215     
Impacted Files Coverage Δ
dec_float.go 100.00% <100.00%> (ø)
dec_float_big.go 100.00% <100.00%> (ø)
dec_int.gen.go 100.00% <100.00%> (ø)
num.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the fix/int-tail-handling branch 5 times, most recently from 3f2d9cd to a9d3917 Compare January 23, 2023 10:43
Also: re-use `floatDigits` set.
@tdakkota tdakkota force-pushed the fix/int-tail-handling branch from a9d3917 to 5127e9c Compare January 23, 2023 14:54
@tdakkota tdakkota force-pushed the fix/int-tail-handling branch from 5127e9c to 03c1e5e Compare January 24, 2023 05:42
@tdakkota tdakkota marked this pull request as ready for review January 24, 2023 06:03
@tdakkota tdakkota merged commit 797756e into go-faster:main Jan 24, 2023
@tdakkota tdakkota deleted the fix/int-tail-handling branch January 24, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant