Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fail early in string encoders #72

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e0930c1) compared to base (047bbd6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         3163      3175   +12     
=========================================
+ Hits          3163      3175   +12     
Impacted Files Coverage Δ
w_b64.go 100.00% <100.00%> (ø)
w_float_bits.go 100.00% <100.00%> (ø)
w_str.go 100.00% <100.00%> (ø)
w_str_escape.go 100.00% <100.00%> (ø)
w_stream.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as draft January 31, 2023 13:18
@tdakkota tdakkota force-pushed the perf/writeErr-check branch 3 times, most recently from 52efd97 to a3910c5 Compare February 1, 2023 12:21
@tdakkota tdakkota force-pushed the perf/writeErr-check branch from a3910c5 to e0930c1 Compare February 1, 2023 12:23
@tdakkota tdakkota marked this pull request as ready for review February 1, 2023 12:29
@tdakkota tdakkota merged commit 9a31093 into go-faster:main Feb 1, 2023
@tdakkota tdakkota deleted the perf/writeErr-check branch February 1, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant