Light maintenance #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nobody use that anymore.
At the time of making that change, tests have been failing for a long (?) time due to a change in golang parsing. When that code was written, fmt.Sscanf was accepting 0x and -0x (without digit), which is why the original author also accepted it in the config parsing. This is not the case anymore, and this commit only reflect the reality of things.
hiddeco
reviewed
Mar 3, 2023
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
pjbgf
requested changes
Mar 6, 2023
Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
|
BTW, I found out about two maintained fork of The first one apparently has a very very nice capability: being able to edit a config file without deleting the comments a user might have put there. It would be great to cherry pick those commits. See for example git-bug/git-bug#1022 how that can cause problems. |
|
@MichaelMure as for the changes in other forks, it would be better to ask the authors whether they want to upstream their changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a form of light maintenance on this repo. Details are in each commit, but TL;DR: