Skip to content

Commit

Permalink
Add tooltip to describe LFS table column and color delete LFS file
Browse files Browse the repository at this point in the history
…button red (#26181)

Fix: #26152
Thease changes are related to UX and accessibility changes in desktop
mode.

<img width="50" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/30a75b50-4f8d-4108-9219-2c69b2a8fa6f">

Also  this is incomplete header 
<img width="264" alt="image"
src="https://github.com/go-gitea/gitea/assets/80308335/87837076-dfc7-4a68-863a-795edf61eb02">
Lets add a tooltip if it is applicable or add `title` attribute so that
it will be clearly visible.

After 

![image](https://github.com/go-gitea/gitea/assets/80308335/e1f91458-a0ab-4a9a-b32a-d1eaaac05b37)

![image](https://github.com/go-gitea/gitea/assets/80308335/fe2031d3-0b26-427f-8438-49e8f54bc12f)
  • Loading branch information
puni9869 committed Jul 27, 2023
1 parent bd6ef71 commit 16afe4f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions templates/repo/settings/lfs.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
<td>{{TimeSince .CreatedUnix.AsTime $.locale}}</td>
<td class="right aligned">
<a class="ui primary button" href="{{$.Link}}/find?oid={{.Oid}}&size={{.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a>
<button class="ui basic show-modal icon button" data-modal="#delete-{{.Oid}}">
<span class="btn-octicon btn-octicon-danger" data-tooltip-content="{{$.locale.Tr "repo.editor.delete_this_file"}}">{{svg "octicon-trash"}}</span>
<button class="ui basic show-modal icon button red" data-modal="#delete-{{.Oid}}">
<span class="btn-octicon btn-octicon-danger" data-tooltip-content="{{$.locale.Tr "repo.editor.delete_this_file"}}">{{svg "octicon-trash"}}</span>
</button>
</td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/settings/lfs_pointers.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<th class="four wide">{{.locale.Tr "repo.settings.lfs_pointers.oid"}}</th>
<th class="two wide">{{.locale.Tr "repo.settings.lfs_pointers.inRepo"}}</th>
<th class="two wide">{{.locale.Tr "repo.settings.lfs_pointers.exists"}}</th>
<th class="two wide">{{.locale.Tr "repo.settings.lfs_pointers.accessible"}}</th>
<th class="two wide" data-tooltip-content="{{.locale.Tr "repo.settings.lfs_pointers.accessible"}}">{{.locale.Tr "repo.settings.lfs_pointers.accessible"}}</th>
<th class="three wide"></th>
</tr>
</thead>
Expand Down

0 comments on commit 16afe4f

Please sign in to comment.