Skip to content

Commit

Permalink
Change review content column to type text in db (#9229)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidsvantesson authored and techknowlogick committed Dec 2, 2019
1 parent 33fc48c commit 1aa7e27
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 1 deletion.
2 changes: 2 additions & 0 deletions models/migrations/migrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,8 @@ var migrations = []Migration{
NewMigration("Add comment_id on table notification", addCommentIDOnNotification),
// v109 -> v110
NewMigration("add can_create_org_repo to team", addCanCreateOrgRepoColumnForTeam),
// v110 -> v111
NewMigration("change review content type to text", changeReviewContentToText),
}

// Migrate database to current version
Expand Down
36 changes: 36 additions & 0 deletions models/migrations/v110.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright 2019 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package migrations

import (
"xorm.io/core"
"xorm.io/xorm"
)

func changeReviewContentToText(x *xorm.Engine) error {

if x.Dialect().DBType() == core.MYSQL {
_, err := x.Exec("ALTER TABLE review MODIFY COLUMN content TEXT")
return err
}

if x.Dialect().DBType() == core.ORACLE {
_, err := x.Exec("ALTER TABLE review MODIFY content TEXT")
return err
}

if x.Dialect().DBType() == core.MSSQL {
_, err := x.Exec("ALTER TABLE review ALTER COLUMN content TEXT")
return err
}

if x.Dialect().DBType() == core.POSTGRES {
_, err := x.Exec("ALTER TABLE review ALTER COLUMN content TYPE TEXT")
return err
}

// SQLite doesn't support ALTER COLUMN, and it seem to already make String to _TEXT_ default so no migration needed
return nil
}
2 changes: 1 addition & 1 deletion models/review.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ type Review struct {
ReviewerID int64 `xorm:"index"`
Issue *Issue `xorm:"-"`
IssueID int64 `xorm:"index"`
Content string
Content string `xorm:"TEXT"`

CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
Expand Down

0 comments on commit 1aa7e27

Please sign in to comment.