Skip to content

Commit

Permalink
Fix environments for KaTeX and error reporting (#22453)
Browse files Browse the repository at this point in the history
In #22447 it was noticed that display environments were not working
correctly. This was due to the setting displayMode not being set.

Further it was noticed that the error was not being displayed correctly.

This PR fixes both of these issues by forcibly setting the displayMode
setting and corrects an error in displayError.

Fix #22447

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
  • Loading branch information
zeripath and lunny authored Jan 16, 2023
1 parent 2782c14 commit 1e7f3c1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions web_src/js/markup/math.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function displayError(el, err) {
const target = targetElement(el);
target.remove('is-loading');
target.classList.remove('is-loading');
const errorNode = document.createElement('div');
errorNode.setAttribute('class', 'ui message error markup-block-error mono');
errorNode.textContent = err.str || err.message || String(err);
Expand All @@ -23,13 +23,15 @@ export async function renderMath() {

for (const el of els) {
const source = el.textContent;
const nodeName = el.classList.contains('display') ? 'p' : 'span';
const displayMode = el.classList.contains('display');
const nodeName = displayMode ? 'p' : 'span';

try {
const tempEl = document.createElement(nodeName);
katex.render(source, tempEl, {
maxSize: 25,
maxExpand: 50,
displayMode,
});
targetElement(el).replaceWith(tempEl);
} catch (error) {
Expand Down

0 comments on commit 1e7f3c1

Please sign in to comment.