Update JS dependencies (#19281)

- Upgrade all JS dependencies minus vue and vue-loader
- Adapt to breaking change of octicons
- Update eslint rules
- Tested Swagger UI, sortablejs and prod build

.eslintrc

@@ -280,7 +280,7 @@ rules:
   no-unused-expressions: [2]
   no-unused-labels: [2]
   no-unused-private-class-members: [2]
-  no-unused-vars: [2, {args: all, argsIgnorePattern: ^_, varsIgnorePattern: ^_, caughtErrorsIgnorePattern: ^_, ignoreRestSiblings: false}]
+  no-unused-vars: [2, {args: all, argsIgnorePattern: ^_, varsIgnorePattern: ^_, caughtErrorsIgnorePattern: ^_, destructuredArrayIgnorePattern: ^_, ignoreRestSiblings: false}]
   no-use-before-define: [2, nofunc]
   no-useless-backreference: [0]
   no-useless-call: [2]

integrations/repo_test.go

@@ -155,7 +155,7 @@ func TestViewRepoWithSymlinks(t *testing.T) {
 		return fmt.Sprintf("%s: %s", file, cls)
 	})
 	assert.Len(t, items, 5)
-	assert.Equal(t, "a: svg octicon-file-directory", items[0])
+	assert.Equal(t, "a: svg octicon-file-directory-fill", items[0])
 	assert.Equal(t, "link_b: svg octicon-file-submodule", items[1])
 	assert.Equal(t, "link_d: svg octicon-file-symlink-file", items[2])
 	assert.Equal(t, "link_hi: svg octicon-file-symlink-file", items[3])

modules/base/tool.go

@@ -279,7 +279,7 @@ func EntryIcon(entry *git.TreeEntry) string {
 		}
 		return "file-symlink-file"
 	case entry.IsDir():
-		return "file-directory"
+		return "file-directory-fill"
 	case entry.IsSubModule():
 		return "file-submodule"
 	}

package.json

@@ -8,9 +8,9 @@
   },
   "dependencies": {
     "@claviska/jquery-minicolors": "2.3.6",
-    "@primer/octicons": "16.3.1",
+    "@primer/octicons": "17.0.0",
     "add-asset-webpack-plugin": "2.0.1",
-    "css-loader": "6.6.0",
+    "css-loader": "6.7.1",
     "dropzone": "6.0.0-beta.2",
     "easymde": "2.16.1",
     "esbuild-loader": "2.18.0",
@@ -23,40 +23,40 @@
     "less-loader": "10.2.0",
     "license-checker-webpack-plugin": "0.2.1",
     "mermaid": "8.14.0",
-    "mini-css-extract-plugin": "2.5.3",
-    "monaco-editor": "0.32.1",
+    "mini-css-extract-plugin": "2.6.0",
+    "monaco-editor": "0.33.0",
     "monaco-editor-webpack-plugin": "7.0.1",
     "pretty-ms": "7.0.1",
-    "sortablejs": "1.14.0",
-    "swagger-ui-dist": "4.5.2",
+    "sortablejs": "1.15.0",
+    "swagger-ui-dist": "4.10.0",
     "tributejs": "5.1.3",
     "uint8-to-base64": "0.2.0",
     "vue": "2.6.14",
     "vue-bar-graph": "1.3.1",
     "vue-calendar-heatmap": "0.8.4",
     "vue-loader": "15.9.8",
     "vue-template-compiler": "2.6.14",
-    "webpack": "5.69.1",
+    "webpack": "5.70.0",
     "webpack-cli": "4.9.2",
-    "workbox-routing": "6.5.0",
-    "workbox-strategies": "6.5.0",
+    "workbox-routing": "6.5.2",
+    "workbox-strategies": "6.5.2",
     "worker-loader": "3.0.8",
     "wrap-ansi": "8.0.1"
   },
   "devDependencies": {
-    "eslint": "8.9.0",
+    "eslint": "8.12.0",
     "eslint-plugin-html": "6.2.0",
     "eslint-plugin-import": "2.25.4",
-    "eslint-plugin-unicorn": "41.0.0",
+    "eslint-plugin-unicorn": "41.0.1",
     "eslint-plugin-vue": "8.5.0",
     "jest": "27.5.1",
     "jest-extended": "2.0.0",
     "jest-raw-loader": "1.0.1",
     "postcss-less": "6.0.0",
-    "stylelint": "14.5.3",
+    "stylelint": "14.6.1",
     "stylelint-config-standard": "25.0.0",
     "svgo": "2.8.0",
-    "updates": "13.0.2"
+    "updates": "13.0.4"
   },
   "browserslist": [
     "defaults",

templates/admin/repo/unadopted.tmpl

@@ -25,7 +25,7 @@
 						{{range $dirI, $dir := .Dirs}}
 							<div class="item">
 								<div class="content">
-									<span class="icon">{{svg "octicon-file-directory"}}</span>
+									<span class="icon">{{svg "octicon-file-directory-fill"}}</span>
 									<span class="name">{{$dir}}</span>
 									<div class="right floated content">
 										<button class="ui button submit tiny green adopt show-modal" data-modal="#adopt-unadopted-modal-{{$dirI}}"><span class="icon">{{svg "octicon-plus"}}</span><span class="label">{{$.i18n.Tr "repo.adopt_preexisting_label"}}</span></button>

templates/repo/view_list.tmpl

@@ -62,7 +62,7 @@
 							{{if $entry.IsDir}}
 								{{$subJumpablePathName := $entry.GetSubJumpablePathName}}
 								{{$subJumpablePath := SubJumpablePath $subJumpablePathName}}
-								{{svg "octicon-file-directory"}}
+								{{svg "octicon-file-directory-fill"}}
 								<a href="{{$.TreeLink}}/{{PathEscapeSegments $subJumpablePathName}}" title="{{$subJumpablePathName}}">
 									{{if eq (len $subJumpablePath) 2}}
 										<span class="jumpable-path">{{index  $subJumpablePath 0}}</span>{{index  $subJumpablePath 1}}

templates/user/settings/repos.tmpl

@@ -33,7 +33,7 @@
 											<span><a href="{{$repo.BaseRepo.Link}}">{{$repo.BaseRepo.OwnerName}}/{{$repo.BaseRepo.Name}}</a></span>
 										{{end}}
 									{{else}}
-										<span class="icon">{{svg "octicon-file-directory"}}</span>
+										<span class="icon">{{svg "octicon-file-directory-fill"}}</span>
 										<span class="name">{{$.Owner.Name}}/{{$dir}}</span>
 										<div class="right floated content">
 											{{if $.allowAdopt}}

web_src/less/_repository.less

@@ -334,7 +334,7 @@
             margin-right: 10px;
           }
 
-          &.octicon-file-directory,
+          &.octicon-file-directory-fill,
           &.octicon-file-submodule {
             color: var(--color-primary);
           }