Fix sorting admin user list by last login (#22081)

Admin User Account list sort `updated_unix` is not the same as "Last Sign-In"
go-gitea · Dec 12, 2022 · 352a50d · 352a50d
1 parent c9ef03a
commit 352a50d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/routers/web/explore/user.go b/routers/web/explore/user.go
@@ -68,6 +68,10 @@ func RenderUserSearch(ctx *context.Context, opts *user_model.SearchUserOptions,
 		orderBy = "`user`.updated_unix ASC"
 	case "reversealphabetically":
 		orderBy = "`user`.name DESC"
+	case "lastlogin":
+		orderBy = "`user`.last_login_unix ASC"
+	case "reverselastlogin":
+		orderBy = "`user`.last_login_unix DESC"
 	case UserSearchDefaultSortType: // "alphabetically"
 	default:
 		orderBy = "`user`.name ASC"

diff --git a/templates/admin/user/list.tmpl b/templates/admin/user/list.tmpl
@@ -76,9 +76,9 @@
 						<th>{{.locale.Tr "admin.users.2fa"}}</th>
 						<th>{{.locale.Tr "admin.users.repos"}}</th>
 						<th>{{.locale.Tr "admin.users.created"}}</th>
-						<th data-sortt-asc="leastupdate" data-sortt-desc="recentupdate">
+						<th data-sortt-asc="lastlogin" data-sortt-desc="reverselastlogin">
 							{{.locale.Tr "admin.users.last_login"}}
-							{{SortArrow "leastupdate" "recentupdate" $.SortType false}}
+							{{SortArrow "lastlogin" "reverselastlogin" $.SortType false}}
 						</th>
 						<th>{{.locale.Tr "admin.users.edit"}}</th>
 					</tr>